[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <A5ED84D3BB3A384992CBB9C77DEDA4D413806E4C@USINDEM103.corp.hds.com>
Date: Tue, 21 Aug 2012 19:24:09 +0000
From: Seiji Aguchi <seiji.aguchi@....com>
To: Mike Waychison <mikew@...gle.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Luck, Tony (tony.luck@...el.com)" <tony.luck@...el.com>,
"Matthew Garrett (mjg@...hat.com)" <mjg@...hat.com>,
"dzickus@...hat.com" <dzickus@...hat.com>,
"dle-develop@...ts.sourceforge.net"
<dle-develop@...ts.sourceforge.net>,
Satoru Moriya <satoru.moriya@....com>
Subject: RE: [RFC][PATCH v3 2/3] efi_pstore: Introducing workqueue updating
sysfs entries
> > efivars_exit(void)
> > {
> > if (efi_enabled) {
> > + cancel_work_sync(&efivar_work);
>
> Please move this cancel_work_sync() to be before the efi_enabled test.
> efi_enabled here means that we registered __efivars. There may be another driver (gsmi) using the efivars code, so we should
> always be cancelling this work.
>
OK. I will fix it.
I confirmed that gsmi accually called register_efivars().
Thank you for letting me know about this.
Seiji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists