linux-kernel - Re: [PATCH RT 2/2] fix printk flush of messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 21 Aug 2012 15:56:16 -0700
From:	Frank Rowand <frank.rowand@...sony.com>
To:	Michael Thalmeier <michael.thalmeier@...e.at>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<rostedt@...dmis.org>, <stable-rt@...r.kernel.org>
Subject: Re: [PATCH RT 2/2] fix printk flush of messages

added recipients...

On 08/21/12 07:30, Michael Thalmeier wrote:
> Frank Rowand <frank.rowand <at> am.sony.com> writes:
> 
>>
>>
>> Updates console-make-rt-friendly.patch
>>
>> #ifdef CONFIG_PREEMPT_RT_FULL, printk() output is never flushed by
>> printk() because:
>> ...
>>
>> On system boot some printk() output is flushed because register_console()
>> and tty_open() call console_unlock().
>>
>> This change also fixes the problem that was previously fixed by
>> preempt-rt-allow-immediate-magic-sysrq-output-for-preempt_rt_full.patch
>>
>> Signed-off-by: Frank Rowand <frank.rowand <at> am.sony.com>
>>
>> ---
>>  kernel/printk.c |    2 	1 +	1 -	0 !
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: b/kernel/printk.c
>> ===================================================================
>> --- a/kernel/printk.c
>> +++ b/kernel/printk.c
>> @@ -847,7 +847,7 @@ static int console_trylock_for_printk(un
>>  	int retval = 0, wake = 0;
>>  #ifdef CONFIG_PREEMPT_RT_FULL
>>  	int lock = !early_boot_irqs_disabled && !irqs_disabled_flags(flags) &&
>> -		!preempt_count();
>> +		(preempt_count() <= 1);
>>  #else
>>  	int lock = 1;
>>  #endif
>>
>>
> 
> I have seen that this patch is applied in the 3.4 stable rt series.
> As we are using the 3.0 stable rt kernel I have tested this patch on this
> kernel series (on a Freescale i.MX31 based board) and have not found any
> problems so far.
> Is there something I have missed why this patch has not found its way
> in the 3.0 series ?
> 
> Thanks in advance,
> Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/