linux-kernel - Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Aug 2012 06:44:17 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Tony Prisk <linux@...sktech.co.nz>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-fbdev@...r.kernel.org, Russell King <linux@....linux.org.uk>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	devicetree-discuss@...ts.ozlabs.org, linux-usb@...r.kernel.org,
	vt8500-wm8505-linux-kernel@...glegroup.com,
	linux-kernel@...r.kernel.org,
	Rob Herring <rob.herring@...xeda.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Landley <rob@...dley.net>, linux-serial@...r.kernel.org,
	rtc-linux@...glegroups.com, Stephen Warren <swarren@...dia.com>,
	Alan Cox <alan@...ux.intel.com>,
	Mike Turquette <mturquette@...com>
Subject: Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for

On Wednesday 22 August 2012, Tony Prisk wrote:
> The original patch was very simple, but I revisited it to fix other
> issues and forgot to add the relevant comments.
> 
> Port size is changed to fix a problem - WM8505 actually had 6 uart's
> defined in platform data but the vt8500_ports variable was only 4.
> 
> I have added devicetree port id support as well.

If you do multiple things in one driver, you should normally send multiple
patches as well, each with a description why that change is done.
It may seem silly at first to send out a one-line patch next to a 100-line
patch for the same file, but those cases are actually the ones where it's
most important.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/