linux-kernel - Re: [PATCH] perf tools: Fix 'No libunwind found' make warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120822084017.GA21581@gmail.com>
Date:	Wed, 22 Aug 2012 10:40:17 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...radead.org>,
	linux-kernel@...r.kernel.org, Andi Kleen <andi@...stfloor.org>,
	Ben Hutchings <ben@...adent.org.uk>,
	Borislav Petkov <borislav.petkov@....com>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	David Ahern <dsahern@...il.com>,
	Feng Tang <feng.tang@...el.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	Paul Mackerras <paulus@...ba.org>,
	Pekka Enberg <penberg@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Robert Richter <robert.richter@....com>,
	Sedat Dilek <sedat.dilek@...il.com>,
	Stephane Eranian <eranian@...gle.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ulrich Drepper <drepper@...il.com>, arnaldo.melo@...il.com,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH] perf tools: Fix 'No libunwind found' make warning message


* Jiri Olsa <jolsa@...hat.com> wrote:

> On Tue, Aug 21, 2012 at 11:36:28AM +0200, Jiri Olsa wrote:
> > On Tue, Aug 21, 2012 at 11:32:31AM +0200, Ingo Molnar wrote:
> > > 
> > > * Arnaldo Carvalho de Melo <acme@...radead.org> wrote:
> > > 
> > 
> > SNIP
> > 
> > > 
> > > One minor observation, the Makefile tells us:
> > > 
> > > Makefile:496: No libunwind found. Please install libunwind >= 0.99
> > > 
> > > I guess that should be libunwind-dev[el], right? Plain libunwind 
> > > is not enough.
> > 
> > right, will fix it
> > 
> > thanks,
> > jirka
> 
> ---
> Changing error message when libunwind support is not found
> to inform properly to install libunwind-dev[el] package.
> 
> Reported-by: Ingo Molnar <mingo@...e.hu>
> Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> ---
>  tools/perf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 6bd888d..218cdb5 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -493,7 +493,7 @@ endif
>  
>  FLAGS_UNWIND=$(LIBUNWIND_CFLAGS) $(ALL_CFLAGS) $(LIBUNWIND_LDFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) $(LIBUNWIND_LIBS)
>  ifneq ($(call try-cc,$(SOURCE_LIBUNWIND),$(FLAGS_UNWIND)),y)
> -	msg := $(warning No libunwind found. Please install libunwind >= 0.99);
> +	msg := $(warning No libunwind found, disables post unwind support. Please install libunwind-dev[el] >= 0.99);

s/disables/disable

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/