linux-kernel - Re: [PATCH] media/radio/shark2: Fix build error caused by missing dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5034F932.4000405@redhat.com>
Date:	Wed, 22 Aug 2012 17:22:26 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	linux-media@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media/radio/shark2: Fix build error caused by missing
 dependencies

Hi,

I've a better fix for this here:
http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6

I already send a pull-req for this to Mauro a while ago, Mauro?

Regards,

Hans

On 08/22/2012 05:16 PM, Guenter Roeck wrote:
> Fix build error:
>
> ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
> ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
>
> which is seen if RADIO_SHARK2 is enabled, but LEDS_CLASS is not.
>
> Since RADIO_SHARK2 depends on NEW_LEDS and LEDS_CLASS, select both if
> it is enabled.
>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>   drivers/media/radio/Kconfig |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
> index 8090b87..bee4bee 100644
> --- a/drivers/media/radio/Kconfig
> +++ b/drivers/media/radio/Kconfig
> @@ -77,6 +77,8 @@ config RADIO_SHARK
>   config RADIO_SHARK2
>   	tristate "Griffin radioSHARK2 USB radio receiver"
>   	depends on USB
> +	select NEW_LEDS
> +	select LEDS_CLASS
>   	---help---
>   	  Choose Y here if you have this radio receiver.
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/