linux-kernel - Re: [PATCH v2] net: add new QCA alx ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120822.234019.1546353507351890178.davem@davemloft.net>
Date:	Wed, 22 Aug 2012 23:40:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiong@....qualcomm.com
Cc:	cjren@....qualcomm.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, qca-linux-team@...lcomm.com,
	nic-devel@...lcomm.com, rodrigue@....qualcomm.com
Subject: Re: [PATCH v2] net: add new QCA alx ethernet driver

From: "Huang, Xiong" <xiong@....qualcomm.com>
Date: Thu, 23 Aug 2012 06:35:40 +0000

>> This is why we require that portable, sane, interfaces are added to ethtool for
>> driver diagnostics.  That way users can perform a task in the same way
>> regardless of what hardware and driver are underneath.
> 
> I quite agree you on using ethtool to implement it. we did consider it. 
> But ethtool has some limitation, for example, the NIC has built-in OTP (TWSI interface)
> And Flash (External SPI interface),  their properties are quite different with EEPROM which
> Ethtool supports.
> To support such memory (OTP/Flash), we need additional input parameters.

Then add a new ethtool operation to support your use case, that's
exactly what I was telling you to do.

Did it really not occur to you that you perhaps you should extend
existing generic facilities to suit your needs instead of creating
private facilities that no other driver can use?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/