linux-kernel - Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Aug 2012 09:23:55 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	Yann Cantin <yann.cantin@...oste.net>
Cc:	linux-input@...r.kernel.org, linux-usb@...r.kernel.org,
	gregkh@...uxfoundation.org, dmitry.torokhov@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

On Thursday 23 August 2012 00:11:54 Yann Cantin wrote:
> +static int ebeam_resume(struct usb_interface *intf)
> +{
> +       struct ebeam_device *ebeam = usb_get_intfdata(intf);
> +       struct input_dev *input = ebeam->input;
> +       int result = 0;
> +
> +       mutex_lock(&input->mutex);
> +       if (input->users)
> +               result = usb_submit_urb(ebeam->irq, GFP_NOIO);
> +       mutex_unlock(&input->mutex);
> +
> +       return result;
> +}
> +
> +static int ebeam_reset_resume(struct usb_interface *intf)
> +{
> +       struct ebeam_device *ebeam = usb_get_intfdata(intf);
> +       struct input_dev *input = ebeam->input;
> +       int err = 0;
> +
> +       /* restart IO if needed */
> +       mutex_lock(&input->mutex);
> +       if (input->users)
> +               err = usb_submit_urb(ebeam->irq, GFP_NOIO);
> +       mutex_unlock(&input->mutex);
> +
> +       return err;
> +}

These functions are identical. You should unify them.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/