linux-kernel - Re: [PATCH] x86: mce: Honour bios-set CMCI threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Aug 2012 14:29:20 +0200
From:	Borislav Petkov <bp@...64.org>
To:	"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
Cc:	Borislav Petkov <bp@...64.org>, tony.luck@...el.com,
	andi@...stfloor.org, gong.chen@...ux.intel.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, mingo@...hat.com, tglx@...utronix.de,
	linux-edac@...r.kernel.org, ananth@...ibm.com,
	Chris McDermott <lcm@...ibm.com>, masbock@...ux.vnet.ibm.com
Subject: Re: [PATCH] x86: mce: Honour bios-set CMCI threshold

On Thu, Aug 23, 2012 at 05:38:05PM +0530, Naveen N. Rao wrote:
> Sure - that sounds like a good idea. Further, a #define can be used to
> avoid the need to change other references, though I'm not sure it's
> considered good practice:
>
> #define mce_bios_cmci_threshold boot_flags.mce_bios_cmci_threshold

That would hide the fact that this flag is part of the boot_flags struct
and would obfuscate the code. We can always add it later though, if it
makes sense.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/