linux-kernel - Re: [ 43/46] KVM: x86 emulator: fix byte-sized MOVZX/MOVSX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1345680284.15245.16.camel@deadeye.wl.decadent.org.uk>
Date:	Thu, 23 Aug 2012 01:04:44 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Marcelo Tosatti <mtosatti@...hat.com>,
	Avi Kivity <avi@...hat.com>
Subject: Re: [ 43/46] KVM: x86 emulator: fix byte-sized MOVZX/MOVSX

On Sun, 2012-08-19 at 20:59 -0700, Greg Kroah-Hartman wrote:
> From: Greg KH <gregkh@...uxfoundation.org>
> 
> 3.5-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Avi Kivity <avi@...hat.com>
> 
> (cherry picked from commit 361cad2b50a2c92b91b6f568db860fabad3bf149)
> 
> Commit 2adb5ad9fe1 removed ByteOp from MOVZX/MOVSX, replacing them by
> SrcMem8, but neglected to fix the dependency in the emulation code
> on ByteOp.  This caused the instruction not to have any effect in
> some circumstances.
> 
> Fix by replacing the check for ByteOp with the equivalent src.op_bytes == 1.
[...]

Also needed for 3.4, based on the commit that's blamed.

Ben.

-- 
Ben Hutchings
Experience is what causes a person to make new mistakes instead of old ones.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)