linux-kernel - Re: [PATCH] tools lib traceevent: Modify header to work in C++ programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1345735029.5069.60.camel@gandalf.local.home>
Date:	Thu, 23 Aug 2012 11:17:09 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [PATCH] tools lib traceevent: Modify header to work in C++
 programs

On Wed, 2012-08-22 at 15:47 +0900, Namhyung Kim wrote:
> Hi, Steve
> 
> On Tue, 21 Aug 2012 19:13:20 -0400, Steven Rostedt wrote:
> > tools lib traceevent: Modify header to work in C++ programs
> >
> > Replace keyword "private" from event-parse.h to allow it to be
> > used in C++ programs.
> >
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> >
> > diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
> > index 5772ad8..c28713b 100644
> > --- a/tools/lib/traceevent/event-parse.h
> > +++ b/tools/lib/traceevent/event-parse.h
> > @@ -49,7 +49,7 @@ struct pevent_record {
> >  	int			cpu;
> >  	int			ref_count;
> >  	int			locked;		/* Do not free, even if ref_count is zero */
> > -	void			*private;
> > +	void			*r_private;
> 
> This r_ (and p_) prefix make it inconsistent with others. How about
> simply using 'priv' instead?

Sure, sounds good.

I'll update and resend.

Thanks!

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/