linux-kernel - Re: [PATCH] Smack: setprocattr memory leak fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5036531A.7030207@schaufler-ca.com>
Date:	Thu, 23 Aug 2012 08:58:18 -0700
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	David Howells <dhowells@...hat.com>
CC:	LKLM <linux-kernel@...r.kernel.org>,
	LSM <linux-security-module@...r.kernel.org>,
	Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH] Smack: setprocattr memory leak fix

On 8/23/2012 5:48 AM, David Howells wrote:
> Casey Schaufler <casey@...aufler-ca.com> wrote:
>
>> From: Casey Schaufler <casey@...aufler-ca.com>
>> Subject: [PATCH] Smack: setprocattr memory leak fix
>>
>> The data structure allocations being done in prepare_creds
>> are duplicated in smack_setprocattr. This results in the
>> structure allocated in prepare_creds being orphaned and
>> never freed. The duplicate code is removed from
>> smack_setprocattr.
>>
>> Targeted for git://git.gitorious.org/smack-next/kernel.git
>>
>> Signed-off-by: Casey Schaufler <casey@...aufler-ca.com>
> Acked-by: David Howells <dhowells@...hat.com>

Thanks for the review.

> Note that I do have a patch to make Smack share rule lists - I've posted it a
> number of times, but I take it you're not interested.

The patch is a big chunk of code and the feature isn't getting
used to the extent that the people who requested it seemed
certain it would be. I don't see there being value in optimizing
the per-task rule lists given the amount of use they get.

>
>   5707  06/13 [To:casey@...auf]  [PATCH 1/3] Smack: Constify some pointers<<Mak
>   5708  06/13   [To:casey@...auf]  [PATCH 2/3] Smack: Further constification<<M
>   5709  06/13   [To:casey@...auf]  [PATCH 3/3] Smack: Use rule list tail sharin
>
> David
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/