linux-kernel - Re: [next-20120823] NOHZ: local_softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+icZUXq9p4yOuse5dzCb2FGmgSKdU8ufDkDcTjWJ0dE79tvUg@mail.gmail.com>
Date:	Thu, 23 Aug 2012 18:06:23 +0200
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	paulmck@...ux.vnet.ibm.com
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Paul McKenney <paul.mckenney@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
	linux-next <linux-next@...r.kernel.org>
Subject: Re: [next-20120823] NOHZ: local_softirq_pending 200 on s/r

On Thu, Aug 23, 2012 at 5:43 PM, Paul E. McKenney
<paulmck@...ux.vnet.ibm.com> wrote:
> On Thu, Aug 23, 2012 at 12:46:37PM +0200, Thomas Gleixner wrote:
>> On Thu, 23 Aug 2012, Sedat Dilek wrote:
>>
>> > Hi,
>> >
>> > this week I was seeing the below NOHZ messages in my logs especially
>> > when suspending and resuming.
>> >
>> > Currently, I am using linux-next (next-20120823) on Ubuntu/precise
>> > AMD64 with a Intel S(a)N(dy)B(ridge)-CPU.
>> >
>> > $ dmesg | grep -A1 -B1 -i nohz
>> > [  720.331819] Disabling non-boot CPUs ...
>> > [  720.332035] NOHZ: local_softirq_pending 200
>> > [  720.434312] smpboot: CPU 1 is now offline
>> > [  720.434825] NOHZ: local_softirq_pending 200
>> > [  720.538237] smpboot: CPU 2 is now offline
>> > [  720.538676] NOHZ: local_softirq_pending 200
>> > [  720.642162] smpboot: CPU 3 is now offline
>> >
>> > If I manually disable the cpuX... First I did not see NOHZ messages
>> > but then there were some lines seen especially when cpuX went offline
>> > (here: cpu1)
>> >
>> > # echo 0 >/sys/devices/system/cpu/cpu1/online
>> >
>> > [ dmeg ]
>> > [ 2605.515771] smpboot: CPU 1 is now offline
>> >
>> > The same with cpu2 and cpu3.
>
> Hmmm...  RCU is actually relying on being able to prevent entry into idle
> by raising softirq.  This is needed for the aggressive energy-efficiency
> CONFIG_RCU_FAST_NO_HZ feature of RCU.  Therefore, I propose the patch
> shown below.
>
> Sedat, does this patch help?
>
>                                                         Thanx, Paul
>
>> > Jack Winter confirmed to see similiar NOHZ messages also on
>> > v3.4.9-rt17 kernel (CPU: Core2Duo when no suspend performed):
>> >
>> > [15223.171585] NOHZ: local_softirq_pending 08
>>
>> That's a different issue. That's a pending networking softirq when we
>> go idle. Unrelated to the RCU / hotplug issue you are observing.
>>
>> > So, the issue is seen on linux-next and -rt kernels.
>> >
>> > According to Thomas "softirq 0x200 is the RCU one" and he requested me
>> > to address the issue to Paul on #linux-rt.
>> >
>> > Regards,
>> > - Sedat -
>
> time: RCU permitted to stop idle entry via softirq
>
> RCU needs to be able to use softirq to stop idle entry in order to
> be able to drain RCU callbacks from the current CPU, which in turn
> enables faster entry into dyntick-idle mode, which in turn reduces power
> consumption.  This commit therefore silences the error message that is
> sometimes produced when the going-idle CPU suddenly finds that it has
> an RCU_SOFTIRQ to process.
>
> Signed-off-by: Paul E. McKenney <paul.mckenney@...aro.org>
>
> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> index c5f856a..c0359d2 100644
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -430,6 +430,8 @@ enum
>         NR_SOFTIRQS
>  };
>
> +const int softirq_stop_idle_mask = (~(1 << RCU_SOFTIRQ));
> +
>  /* map softirq index to softirq name. update 'softirq_to_name' in
>   * kernel/softirq.c when adding a new softirq.
>   */
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index 024540f..84932cf 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -436,7 +436,8 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
>         if (unlikely(local_softirq_pending() && cpu_online(cpu))) {
>                 static int ratelimit;
>
> -               if (ratelimit < 10) {
> +               if (ratelimit < 10 &&
> +                   (local_softirq_pending() & softirq_stop_idle_mask)) {
>                         printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
>                                (unsigned int) local_softirq_pending());
>                         ratelimit++;
>

Applying this patch on top of my local GIT tree results in error-messages:

[...]
  CC      kernel/rcupdate.o
  AS      arch/x86/platform/efi/efi_stub_64.o
  CC      arch/x86/kernel/irqinit.o
  LD      arch/x86/platform/efi/built-in.o
arch/x86/platform/efi/efi_64.o:(.rodata+0x0): multiple definition of
`softirq_stop_idle_mask'
arch/x86/platform/efi/efi.o:(.rodata+0x50): first defined here
make[5]: *** [arch/x86/platform/efi/built-in.o] Error 1
make[4]: *** [arch/x86/platform/efi] Error 2
make[3]: *** [arch/x86/platform] Error 2
make[3]: *** Waiting for unfinished jobs....
[...]

$ LC_ALL=C grep softirq_stop_idle_mask -nr linux-next/arch/x86/platform/efi/
Binary file linux-next/arch/x86/platform/efi/efi.o matches
Binary file linux-next/arch/x86/platform/efi/efi_64.o matches

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/