linux-kernel - Re: [PATCH] kconfig: replace 'oldnoconfig' with 'olddefconfig', what it really does

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1345752601.12440.3.camel@gandalf.local.home>
Date:	Thu, 23 Aug 2012 16:10:01 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Adam Lee <adam8157@...il.com>
Cc:	linux-kernel@...r.kernel.org, Michal Marek <mmarek@...e.cz>,
	Yaakov Selkowitz <yselkowitz@...rs.sourceforge.net>,
	Peter Foley <pefoley2@...izon.net>,
	Paul Bolle <pebolle@...cali.nl>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"open list:KCONFIG" <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH] kconfig: replace 'oldnoconfig' with 'olddefconfig',
 what it really does

Sorry for the late reply.

On Fri, 2012-08-17 at 15:16 +0800, Adam Lee wrote:
> As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't
> set new symbols to 'n', but instead sets it to their default values.
> 
> So, this patch replace 'oldnoconfig' with 'olddefconfig', stop making
> people confused.
> 
> PS: the document in conf.c fixed in another mail, "[PATCH] [Signed-off]
> kconfig: document oldnoconfig to what it really does in conf.c"

The reason that I didn't make this change myself is that I'm afraid that
things depend on 'oldnoconfig' existing. For example, ktest.pl has it
hardcoded. That may not be the only script that uses it.

I think a better solution would be to make oldnoconfig do just that, set
everything to 'n' as the name implies, and we can create a olddefconfig
to do what it does now.

-- Steve


> 
> Signed-off-by: Adam Lee <adam8157@...il.com>
> ---
>  scripts/kconfig/Makefile     |  6 +++---
>  scripts/kconfig/conf.c       | 18 +++++++++---------
>  tools/testing/ktest/ktest.pl | 15 +++++++--------
>  3 files changed, 19 insertions(+), 20 deletions(-)
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/