linux-kernel - Re: [PATCH v7 02/12] x86/Kconfig: Add config switch for CPU0 hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120824093436.GC3019@liondog.tnic>
Date:	Fri, 24 Aug 2012 11:34:36 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Fenghua Yu <fenghua.yu@...el.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	H Peter Anvin <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Asit K Mallick <asit.k.mallick@...el.com>,
	Tony Luck <tony.luck@...el.com>,
	Arjan Dan De Ven <arjan@...ux.intel.com>,
	Suresh B Siddha <suresh.b.siddha@...el.com>,
	Len Brown <len.brown@...el.com>,
	"Srivatssa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	Chen Gong <gong.chen@...ux.intel.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-pm <linux-pm@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH v7 02/12] x86/Kconfig: Add config switch for CPU0 hotplug

On Thu, Aug 23, 2012 at 05:56:01PM -0700, Fenghua Yu wrote:
> From: Fenghua Yu <fenghua.yu@...el.com>
> 
> New config switch CONFIG_BOOTPARAM_HOTPLUG_CPU0 sets default state of whether
> the CPU0 hotplug is on or off.
> 
> If the switch is off, CPU0 is not hotpluggable by default. But the CPU0 hotplug
> feature can still be turned on by kernel parameter cpu0_hotplug at boot.
> 
> If the switch is on, CPU0 is always hotpluggable. The default value of
> the switch is off.
> 
> Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> ---
>  arch/x86/Kconfig |   29 +++++++++++++++++++++++++++++
>  1 files changed, 29 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 1d91dac..31c8b89 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1711,6 +1711,35 @@ config HOTPLUG_CPU
>  	    automatically on SMP systems. )
>  	  Say N if you want to disable CPU hotplug.
>  
> +config BOOTPARAM_HOTPLUG_CPU0
> +	bool "Set default setting of cpu0_hotpluggable"

Why not change this boot option into something more understandable like

	bool "BSP hotpluggable by default"

or similar?

And, btw, maybe I didn't catch this earlier, but why is in all
user-visible options the thing called "cpu0_*"? Wouldn't it be better to
call it "bsp_*"?

Thanks.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/