linux-kernel - Re: [PATCH] tty: Added a CONFIG_TTY option to allow removal of TTY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120824141537.63274081@pyramind.ukuu.org.uk>
Date:	Fri, 24 Aug 2012 14:15:37 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Joe Millenbach <jmillenbach@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Josh Triplett <josh@...htriplett.org>,
	team-fjord@...glegroups.com
Subject: Re: [PATCH] tty: Added a CONFIG_TTY option to allow removal of TTY

On Thu, 23 Aug 2012 18:14:48 -0700
Joe Millenbach <jmillenbach@...il.com> wrote:

> ---------- Forwarded message ----------
> From: Joe Millenbach <jmillenbach@...il.com>
> Date: Thu, Aug 23, 2012 at 5:56 PM
> Subject: Re: [PATCH] tty: Added a CONFIG_TTY option to allow removal of TTY
> To: Alan Cox <alan@...rguk.ukuu.org.uk>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Alan Cox
> <alan@...ux.intel.com>, linux-serial@...r.kernel.org,
> linux-kernel@...r.kernel.org, Josh Triplett <josh@...htriplett.org>,
> team-fjord@...glegroups.com
> 
> 
> On Tue, Aug 21, 2012 at 6:20 AM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> >
> > ...
> >
> > >  config MOUSE_PS2
> > >       tristate "PS/2 mouse"
> > > +     depends on TTY
> >
> > It shouldn't. It would be good to understand why this occurs.
> 
> 
> If I enable this config option, and turn off TTY I get the below errors.
> 
> drivers/built-in.o: In function `serport_ldisc_read':
> serport.c:(.text+0x1aace6): undefined reference to `tty_name'
> serport.c:(.text+0x1aad57): undefined reference to `tty_name'
> drivers/built-in.o: In function `serport_init':
> serport.c:(.init.text+0x8478): undefined reference to `tty_register_ldisc'
> drivers/built-in.o: In function `serport_exit':
> serport.c:(.exit.text+0xb29): undefined reference to `tty_unregister_ldisc'
> 
> All because MOUSE_PS2 depends on SERIO, just like a lot of entries I
> blocked.  I assume this means I should keep the dependency on TTY.
> Unfortunately, I don't have time to dig deeper for the true cause of the
> dependency right now.

The true cause I think is that serio/serport.c should depend on tty to be
built but the ps/2 mouse bits shouldn't.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/