linux-kernel - Re: Unable to mount NFSROOT: pcie change breaks e1000?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 24 Aug 2012 22:42:07 +0800
From:	Jiang Liu <liuj97@...il.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	Fengguang Wu <fengguang.wu@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Unable to mount NFSROOT: pcie change breaks e1000?

On 08/24/2012 12:12 AM, Bjorn Helgaas wrote:
> On Thu, Aug 23, 2012 at 9:03 AM, Jiang Liu <liuj97@...il.com> wrote:
>> Hi Bjorn,
>>         Could you please help to fold this small patch into
>> "[5/40] PCI/core: Use PCI Express Capability accessors"?
>> It fixes a bug reported by Fengguang.
> 
> Thanks, I folded it in.  I looked briefly at whether a similar fix is
> needed in pci_restore_pcie_state().  I don't *think* so, but it
> wouldn't hurt for you to also double-check and let me know if it does.

I think it's optional to add a "pci_is_pcie()" check for pci_restore_pcie_state().
pci_find_saved_cap(dev, PCI_CAP_ID_EXP) should return NULL for non-PCIe device.

--Gerry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/