linux-kernel - Re: [PATCH 2/5] mm/memblock: rename get_allocated_memblock_reserved_regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120824153902.GA22555@merkur.ravnborg.org>
Date:	Fri, 24 Aug 2012 17:39:02 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Michal Hocko <mhocko@...e.cz>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Minchan Kim <minchan@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Gavin Shan <shangw@...ux.vnet.ibm.com>
Subject: Re: [PATCH 2/5] mm/memblock: rename
	get_allocated_memblock_reserved_regions_info()

On Fri, Aug 24, 2012 at 10:33:37PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
> 
> Rename get_allocated_memblock_reserved_regions_info() to
> memblock_reserved_regions_info() so that the function name
> looks more short and has prefix "memblock".
> 
> Signed-off-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
> ---
>  include/linux/memblock.h |    2 +-
>  mm/memblock.c            |    2 +-
>  mm/nobootmem.c           |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index 569d67d..ab7b887 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -50,7 +50,7 @@ phys_addr_t memblock_find_in_range_node(phys_addr_t start, phys_addr_t end,
>  				phys_addr_t size, phys_addr_t align, int nid);
>  phys_addr_t memblock_find_in_range(phys_addr_t start, phys_addr_t end,
>  				   phys_addr_t size, phys_addr_t align);
> -phys_addr_t get_allocated_memblock_reserved_regions_info(phys_addr_t *addr);
> +phys_addr_t memblock_reserved_regions_info(phys_addr_t *addr);
When you anyway change the prototype a description of what this function
is supposed to be used for would be good.
Many memblock function lacks this :-(

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/