linux-kernel - Re: [PATCH V5 0/5] clk: mmp: add clock framework for mmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120825002151.18366.99434@nucleus>
Date:	Fri, 24 Aug 2012 17:21:51 -0700
From:	Mike Turquette <mturquette@...aro.org>
To:	Chao Xie <xiechao.mail@...il.com>, haojian.zhuang@...il.com,
	viresh.linux@...il.com, s.hauer@...gutronix.de,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	chao.xie@...vell.com, arnd@...db.de
Subject: Re: [PATCH V5 0/5] clk: mmp: add clock framework for mmp

Quoting Chao Xie (2012-08-19 19:55:10)
> From: Chao Xie <chao.xie@...vell.com>
>  arch/arm/mach-mmp/Kconfig    |    3 +
>  drivers/clk/Makefile         |    3 +
>  drivers/clk/mmp/Makefile     |    9 +
>  drivers/clk/mmp/clk-apbc.c   |  152 ++++++++++++++
>  drivers/clk/mmp/clk-apmu.c   |   97 +++++++++
>  drivers/clk/mmp/clk-frac.c   |  153 ++++++++++++++
>  drivers/clk/mmp/clk-mmp2.c   |  449 ++++++++++++++++++++++++++++++++++++++++++
>  drivers/clk/mmp/clk-pxa168.c |  346 ++++++++++++++++++++++++++++++++
>  drivers/clk/mmp/clk-pxa910.c |  320 ++++++++++++++++++++++++++++++
>  drivers/clk/mmp/clk.h        |   35 ++++

Looks like you are not removing your arch/arm/mach-mmp/clock.c.  Is that
intentional?

When I apply your series against v3.6-rc3 I find that compilation breaks
with mmp2_defconfig due to conflicting definitions for the clk api
(clk_enable, clk_set_rate, etc).  This is not surprising since your
legacy clock code is neither deleted nor removed from compilation
conditionally by checking for CONFIG_COMMON_CLK.

Did I somehow manage to misapply your patches or should your patches
have removed the arch-specific clock framework as well?

Regards,
Mike

>  10 files changed, 1567 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/clk/mmp/Makefile
>  create mode 100644 drivers/clk/mmp/clk-apbc.c
>  create mode 100644 drivers/clk/mmp/clk-apmu.c
>  create mode 100644 drivers/clk/mmp/clk-frac.c
>  create mode 100644 drivers/clk/mmp/clk-mmp2.c
>  create mode 100644 drivers/clk/mmp/clk-pxa168.c
>  create mode 100644 drivers/clk/mmp/clk-pxa910.c
>  create mode 100644 drivers/clk/mmp/clk.h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/