linux-kernel - Re: [PATCH 02/14] aoe: kernel thread handles I/O completions for simple locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2a9xj6c6a.fsf@coraid.com>
Date:	Fri, 24 Aug 2012 20:35:41 -0400
From:	Ed Cashin <ecashin@...aid.com>
To:	linux-kernel@...r.kernel.org
Cc:	Andrew Morton <akpm@...ux-foundation.org>, ecashin@...aid.com
Subject: Re: [PATCH 02/14] aoe: kernel thread handles I/O completions for simple locking

Andrew Morton <akpm@...ux-foundation.org> writes:

> On Fri, 17 Aug 2012 21:24:08 -0400
> Ed Cashin <ecashin@...aid.com> wrote:
...
>> +	sigfillset(&blocked);
>> +	sigprocmask(SIG_BLOCK, &blocked, NULL);
>> +	flush_signals(current);
>
> This is a kernel thread - it shouldn't need to fiddle with signals.
...

Thanks for the feedback.  I'll try out your suggestions and return with
changes and explanations.

-- 
  Ed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/