linux-kernel - Re: [PATCH v2 1/2] apple-gmux: Fix index read functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120826004759.GB20735@ubuntu-mba51>
Date:	Sat, 25 Aug 2012 19:47:59 -0500
From:	Seth Forshee <seth.forshee@...onical.com>
To:	Bernhard Froemel <bfroemel@...il.com>
Cc:	Matthew Garrett <mjg@...hat.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bernhard Froemel <froemel@...rs.tuwien.ac.at>
Subject: Re: [PATCH v2 1/2] apple-gmux: Fix index read functions

On Sat, Aug 25, 2012 at 10:30:48AM +0200, Bernhard Froemel wrote:
> From: Bernhard Froemel <froemel@...rs.tuwien.ac.at>
> 
> Study of Apple's binary driver revealed that the GMUX_READ_PORT should
> be written between calls to gmux_index_wait_ready and
> gmux_index_wait_complete (i.e., the new index protocol must be
> followed). If this is not done correctly, the indexed
> gmux device only partially accepts writes which lead to problems
> concerning GPU switching. Special thanks to Seth Forshee who helped
> greatly with identifying unnecessary changes.
> 
> Signed-off-by: Bernhard Froemel <froemel@...rs.tuwien.ac.at>

This does better match what Apple's driver does. Thanks Bernhard.

Acked-by: Seth Forshee <seth.forshee@...onical.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/