linux-kernel - Re: [PATCH] extcon: arizona: Free MICDET IRQ on error during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <503AB72C.9020505@samsung.com>
Date:	Mon, 27 Aug 2012 08:54:20 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] extcon: arizona: Free MICDET IRQ on error during probe

On 08/27/2012 05:58 AM, Mark Brown wrote:

> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/extcon/extcon-arizona.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index fa2114f..13eafcb 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -488,11 +488,13 @@ static int __devinit arizona_extcon_probe(struct platform_device *pdev)
>  	ret = input_register_device(info->input);
>  	if (ret) {
>  		dev_err(&pdev->dev, "Can't register input device: %d\n", ret);
> -		goto err_fall_wake;
> +		goto err_micdet;
>  	}
>  
>  	return 0;
>  
> +err_micdet:
> +	arizona_free_irq(arizona, ARIZONA_IRQ_MICDET, info);
>  err_fall_wake:
>  	arizona_set_irq_wake(arizona, ARIZONA_IRQ_JD_FALL, 0);
>  err_fall:


Thanks much,

Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>

I will apply this patch to
http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next
and you can check it after some hours.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/