linux-kernel - Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120827165057.GK4339@opensource.wolfsonmicro.com>
Date:	Mon, 27 Aug 2012 09:50:57 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Anthony Olech <anthony.olech.opensource@...semi.com>
Cc:	Liam Girdwood <lrg@...com>, Guenter Roeck <linux@...ck-us.net>,
	Jean Delvare <khali@...ux-fr.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	LKML <linux-kernel@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>
Subject: Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

On Wed, Aug 15, 2012 at 04:05:25PM +0100, Anthony Olech wrote:

> +static int da9058_buck_ramp_voltage(struct regulator_dev *rdev,
> +					unsigned int old_selector,
> +					unsigned int new_selector)
> +{

> +	ret = da9058_set_bits(da9058, regulator->ramp_register,
> +					regulator->ramp_enable_mask);
> +
> +	if (ret)
> +		return ret;

> +	return 2200; /* micro Seconds needed to ramp to new voltage*/

Why is this function writing to the hardware, especially writing the
same value every time?

> +static int da9058_get_fixed_regulator_voltage(struct regulator_dev *rdev)
> +{
> +	struct da9058_regulator *regulator = rdev_get_drvdata(rdev);
> +
> +	if (regulator_is_enabled_regmap(rdev))
> +		return regulator->fixed_voltage;
> +	else
> +		return 0;
> +}

list_voltage_linear()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/