linux-kernel - Re: [PATCH 0/3] uprobes: teach uprobes to clear MMF_HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120827174428.GA438@redhat.com>
Date:	Mon, 27 Aug 2012 19:44:28 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Cc:	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anton Arapov <anton@...hat.com>, linux-kernel@...r.kernel.org,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH 0/3] uprobes: teach uprobes to clear MMF_HAS_UPROBES

Srikar, this is still waiting for your review ;)

FYI, I created the tree to accumulate the acked patches,
kernel.org:/pub/scm/linux/kernel/git/oleg/misc

Currently it has:

	Oleg Nesterov (7):
	      uprobes: kill uprobes_state->count
	      uprobes: kill dup_mmap()->uprobe_mmap(), simplify uprobe_mmap/munmap
	      uprobes: change uprobe_mmap() to ignore the errors but check fatal_signal_pending()
	      uprobes: do not use -EEXIST in install_breakpoint() paths
	      uprobes: introduce MMF_HAS_UPROBES
	      uprobes: fold uprobe_reset_state() into uprobe_dup_mmap()
	      uprobes: remove "verify" argument from set_orig_insn()

	Sebastian Andrzej Siewior (1):
	      uprobes: remove check for uprobe variable in handle_swbp()

	Srikar Dronamraju (1):
	      uprobes: Remove redundant lock_page/unlock_page

You didn't ack Sebastian's patch, but it looks simple. If you
have any objections please let me know.

On 08/19, Oleg Nesterov wrote:
>
> Hello.
>
> On top of "kill uprobes_state->count, add MMF_HAS_UPROBES"
> series.
>
> Once again, I am not sure we really need this (except 1/3).
> Perhaps we could remove uprobe_munmap() instead and forget
> about the false-positive MMF_HAS_UPROBES's.
>
> OTOH, imho it looks a bit more clean this way. Please comment.
>
> diffstat reports the code bloat, but note that the previous
> series removed more code.
>
> Oleg.
>
>  include/linux/sched.h   |    3 +-
>  kernel/events/uprobes.c |   82 +++++++++++++++++++++++++++++++++++++----------
>  2 files changed, 67 insertions(+), 18 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/