linux-kernel - Re: [PATCH] exynos-rng: Depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120827213719.GD4400@opensource.wolfsonmicro.com>
Date:	Mon, 27 Aug 2012 14:37:20 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jeff Mahoney <jeffm@...e.com>
Cc:	Stephen Boyd <sboyd@...eaurora.org>,
	Jonghwa Lee <jonghwa3.lee@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>,
	Mike Turquette <mturquette@...com>
Subject: Re: [PATCH] exynos-rng: Depend on ARCH_EXYNOS

On Mon, Aug 27, 2012 at 05:25:59PM -0400, Jeff Mahoney wrote:
> On 8/27/12 5:18 PM, Stephen Boyd wrote:

> > Hmm the point of making it not depend on ARCH_EXYNOS was so that
> > it would get more build coverage. Is it devm_clk_get() that's
> > missing? I believe Mark Brown sent some patches that move
> > devm_clk_get() to common code so that we don't have these
> > failures[1]. Can you try that patch?

> I'll give it a go since it should fix more than one issue for me. My
> question remains, though: If this hardware is never going to be found
> on powerpc hardware, what difference does it make if there is build
> coverage there?

If you're trying to do some generic API changes or similar it's *much*
easier if you can at least build test a good proportion of the kernel
(or subsytem) with one build even if you've no intention of running the
code.  Having to build lots of different configs to get coverage means
that's likely to get skipped which in turn increases the error rate with
these things.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/