linux-kernel - Re: [PATCH 1/5] drivers:tty:fix up ENOIOCTLCMD error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120827234231.18b971f5@pyramind.ukuu.org.uk>
Date:	Mon, 27 Aug 2012 23:42:31 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Wanlong Gao <gaowanlong@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/5] drivers:tty:fix up ENOIOCTLCMD error handling

On Mon, 27 Aug 2012 15:23:12 +0800
Wanlong Gao <gaowanlong@...fujitsu.com> wrote:

> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
> translated as ENOTTY to user mode.
> For example:
> 	fd = open("/dev/tty", O_RDWR);
> 	ioctl(fd, -1, &argp);
> 
> then the errno should be ENOTTY but not EINVAL.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Wanlong Gao <gaowanlong@...fujitsu.com>

Acked-by: Alan Cox <alan@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/