linux-kernel - RE: [PATCH 2/5] MFD: ti_tscadc: Add support for TI's TSC/ADC MFDevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Aug 2012 10:25:04 +0000
From:	"Patil, Rachna" <rachna@...com>
To:	Matthias Kaehlcke <matthias.list@...hlcke.net>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Dmitry Torokhov <dtor@...l.ru>,
	Jonathan Cameron <jic23@....ac.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: RE: [PATCH 2/5] MFD: ti_tscadc: Add support for TI's TSC/ADC
 MFDevice

Hi,

On Fri, Aug 24, 2012 at 00:18:31, Matthias Kaehlcke wrote:
> Hi,
> 
> El Thu, Aug 23, 2012 at 04:19:57PM +0530 Patil, Rachna ha dit:
> 
> > Add the mfd core driver which supports touchscreen and ADC.
> > With this patch we are only adding infrastructure to support the MFD 
> > clients.
> > 
> > Signed-off-by: Patil, Rachna <rachna@...com>
> > ---
> > diff --git a/drivers/mfd/ti_tscadc.c b/drivers/mfd/ti_tscadc.c ...
> > +static	int __devinit ti_tscadc_probe(struct platform_device *pdev)
> > +{
> > +	struct ti_tscadc_dev		*tscadc;
> > +	int				err, ctrl;
> > +	int				clk_value, clock_rate;
> > +	struct resource			*res;
> > +	struct clk			*clk;
> > +
> > +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	if (!res) {
> > +		dev_err(&pdev->dev, "no memory resource defined.\n");
> > +		return -EINVAL;
> > +	}
> > +
> > +	/* Allocate memory for device */
> > +	tscadc = kzalloc(sizeof(struct ti_tscadc_dev), GFP_KERNEL);
> > +	if (!tscadc) {
> > +		dev_err(&pdev->dev, "failed to allocate memory.\n");
> > +		return -ENOMEM;
> > +	}
> > +
> > +	res = request_mem_region(res->start, resource_size(res), pdev->name);
> > +	if (!res) {
> > +		dev_err(&pdev->dev, "failed to reserve registers.\n");
> > +		err = -EBUSY;
> > +		goto err_free_mem;
> > +	}
> > +
> > +	tscadc->tscadc_base = ioremap(res->start, resource_size(res));
> > +	if (!tscadc->tscadc_base) {
> > +		dev_err(&pdev->dev, "failed to map registers.\n");
> > +		err = -ENOMEM;
> > +		goto err_release_mem;
> > +	}
> > +
> > +	tscadc->irq = platform_get_irq(pdev, 0);
> > +	if (tscadc->irq < 0) {
> > +		dev_err(&pdev->dev, "no irq ID is specified.\n");
> > +		return -ENODEV;
> 
> goto err_iounmap_mem;

Yes. Will add this.

> 
> > ...
> > +err_fail:
> > +	pm_runtime_put_sync(&pdev->dev);
> > +	pm_runtime_disable(&pdev->dev);
> > +	iounmap(tscadc->tscadc_base);
> > +err_release_mem:
> > +	release_mem_region(res->start, resource_size(res));
> > +	mfd_remove_devices(tscadc->dev);
> > +err_free_mem:
> > +	platform_set_drvdata(pdev, NULL);
> 
> shouldn't be necessary as the platform device doesn't exist any longer

Ok. Will remove this.

> 
> > ...
> > +static int __devexit ti_tscadc_remove(struct platform_device *pdev) {
> > +	struct ti_tscadc_dev	*tscadc = platform_get_drvdata(pdev);
> > +	struct resource		*res;
> > +
> > +	tscadc_writel(tscadc, REG_SE, 0x00);
> > +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	iounmap(tscadc->tscadc_base);
> > +	release_mem_region(res->start, resource_size(res));
> > +
> > +	pm_runtime_put_sync(&pdev->dev);
> > +	pm_runtime_disable(&pdev->dev);
> > +
> > +	mfd_remove_devices(tscadc->dev);
> > +	kfree(tscadc);
> > +
> > +	platform_set_drvdata(pdev, NULL);
> 
> same as above

Will correct this as well.

> 
> best regards
> 
> --
> Matthias Kaehlcke
> Embedded Linux Developer
> Amsterdam
> 
>          The only way to do great work is to love what you do
>                             (Steve Jobs)
>                                                                  .''`.
>     using free software / Debian GNU/Linux | http://debian.org  : :'  :
>                                                                 `. `'`
> gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
> 

Thanks & Regards,
Rachna
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/