linux-kernel - Re: [PATCH] staging: ozwpan: remove pointless conditional before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <503D30A6.3000800@ozmodevices.com>
Date:	Tue, 28 Aug 2012 21:57:10 +0100
From:	Rupesh Gujare <rgujare@...odevices.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
CC:	<ckelly@...odevices.com>, <gregkh@...uxfoundation.org>,
	<yongjun_wei@...ndmicro.com.cn>, <devel@...verdev.osuosl.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: ozwpan: remove pointless conditional before
 kfree_skb()

On 28/08/2012 14:11, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Remove pointless conditional before kfree_skb().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>   drivers/staging/ozwpan/ozpd.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
> index 6c287ac..d515714 100644
> --- a/drivers/staging/ozwpan/ozpd.c
> +++ b/drivers/staging/ozwpan/ozpd.c
> @@ -752,8 +752,7 @@ int oz_isoc_stream_create(struct oz_pd *pd, u8 ep_num)
>    */
>   static void oz_isoc_stream_free(struct oz_isoc_stream *st)
>   {
> -	if (st->skb)
> -		kfree_skb(st->skb);
> +	kfree_skb(st->skb);
>   	kfree(st);
>   }
>   /*------------------------------------------------------------------------------
>
>



Acked-by: Rupesh Gujare <rgujare@...odevices.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/