linux-kernel - Re: [PATCH 6/7] workqueue: init 0 for idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOS58YPLYfhSQAGqbZ0i60v0XKqJ15jF9eaEJzk2t+NT5mT=PQ@mail.gmail.com>
Date:	Tue, 28 Aug 2012 00:04:07 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <eag0628@...il.com>
Cc:	Lai Jiangshan <laijs@...fujitsu.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] workqueue: init 0 for idle_rebind.cnt

Hello,

On Mon, Aug 27, 2012 at 9:36 PM, Lai Jiangshan <eag0628@...il.com> wrote:
>> But then the completion could be triggered prematurely, no?
>
> No, the idle_worker_rebind() can't be called until rebind_workers()
> finish counting and release the gcwq->lock.

I see but I still wanna keep it counting from 1.  That's an
established pattern and is more robust.  I really don't see what we're
gaining by doing it differently.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/