linux-kernel - RE: [PATCH] lp8727_charger: use IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A874F61F95741C4A9BA573A70FE3998F41EF19C0@DQHE02.ent.ti.com>
Date:	Wed, 29 Aug 2012 02:00:43 +0000
From:	"Kim, Milo" <Milo.Kim@...com>
To:	Fengguang Wu <fengguang.wu@...el.com>
CC:	Anton Vorontsov <cbouatmailru@...il.com>,
	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Axel Lin <axel.lin@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] lp8727_charger: use IRQF_ONESHOT

> ERROR: Threaded IRQ with no primary handler requested without
> IRQF_ONESHOT
> 
> Make sure threaded IRQs without a primary handler are always request
> with IRQF_ONESHOT
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
> Note: I don't really know much about the situation, feel free to
> ignore it if it's an false warning.
> 
>  cocci-output-25411-2ae2e0-lp8727_charger.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/power/lp8727_charger.c
> +++ b/drivers/power/lp8727_charger.c
> @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
>  	return request_threaded_irq(pchg->client->irq,
>  				NULL,
>  				lp8727_isr_func,
> -				IRQF_TRIGGER_FALLING,
> +				IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
>  				"lp8727_irq",
>  				pchg);
>  }
Thanks for the update.

Acked-by: Milo(Woogyom) Kim <milo.kim@...com>

Best Regards,
Milo



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/