linux-kernel - Re: [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120829020134.GA1761@aaronlu.sh.intel.com>
Date:	Wed, 29 Aug 2012 10:01:36 +0800
From:	Aaron Lu <aaron.lwe@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Borislav Petkov <bp@...64.org>, Lin Ming <minggr@...il.com>,
	Len Brown <lenb@...nel.org>, Aaron Lu <aaron.lu@....com>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are
 found

On Fri, Aug 24, 2012 at 03:36:21PM -0700, Joe Perches wrote:
> On Thu, 2012-08-23 at 15:26 +0200, Borislav Petkov wrote:
> > On Fri, Aug 10, 2012 at 10:05:53AM +0800, Aaron Lu wrote:
> > > commit a606dac368eed5696fb38e16b1394f1d049c09e9 adds support to link
> > > devices which have _PRx, if a device does not have _PRx, a warning
> > > message will be printed.
> > > 
> > > This commit is for ZPODD on Intel's platform, on AMD's platform, there
> > > is no _PRx to support ZPODD, we use _PSx.
> > > 
> > > So instead of printing a useless warning message on AMD's platform,
> > > changing the print level to DEBUG to suppress this message.
> []
> > > diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> []
> > > @@ -460,7 +460,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
> > >  	return ret;
> > >  
> > >  no_power_resource:
> > > -	printk(KERN_WARNING PREFIX "Invalid Power Resource to register!");
> > > +	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
> 
> Perhaps add something like:
> 	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
> 		printk(etc...)
> instead?

Sorry for not describing this problem clear, this would also occur on
Intel platforms as long as that device we are calling this register
function on does not have any power resource attached to it.

So the problem is actually, does the acpi_power_resource_register_device
function expect such input devices that they do not have any power
resource attached? If yes, then it shouldn't complain with a warning
message; if no, then we should probably check these conditions before
making such a call.

Looking at the function itself, I think it expects such devices so a
warning message here is not appropriate.

-Aaron
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/