linux-kernel - Re: [PATCH 03/13] perf tools: drop asm/byteorder.h wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <503E411D.2040406@gmail.com>
Date:	Wed, 29 Aug 2012 10:19:41 -0600
From:	David Ahern <dsahern@...il.com>
To:	Irina Tirdea <irina.tirdea@...il.com>
CC:	Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 03/13] perf tools: drop asm/byteorder.h wrapper

On 8/28/12 3:59 PM, Irina Tirdea wrote:
> Wrapping asm/byteorder.h will also replace the glibc header,
> not only the kernel one. asm/byteorder.h further includes
> architecture dependent headers that define endianess.
>
> Some systems (e.g. Android) need constant definitions that
> depend on endianess (e.g. __constant_htonl).
>
> In file included from bionic/libc/include/netinet/tcp.h:32:0,
>                   from kernel/intel/tools/perf/util/util.h:74,
>                   from kernel/intel/tools/perf/util/cache.h:5,
>                   from kernel/intel/tools/perf/util/abspath.c:1:
> bionic/libc/kernel/common/linux/tcp.h:61:2:
> error: enumerator value for 'TCP_FLAG_CWR' is not an integer constant
> bionic/libc/kernel/common/linux/tcp.h:62:2:
> error: enumerator value for 'TCP_FLAG_ECE' is not an integer constant
> bionic/libc/kernel/common/linux/tcp.h:63:2:
> error: enumerator value for 'TCP_FLAG_URG' is not an integer constant
> bionic/libc/kernel/common/linux/tcp.h:64:2:
> error: enumerator value for 'TCP_FLAG_ACK' is not an integer constant
> bionic/libc/kernel/common/linux/tcp.h:65:2:
> error: enumerator value for 'TCP_FLAG_PSH' is not an integer constant
> bionic/libc/kernel/common/linux/tcp.h:66:2:
> error: enumerator value for 'TCP_FLAG_RST' is not an integer constant
> bionic/libc/kernel/common/linux/tcp.h:67:2:
> error: enumerator value for 'TCP_FLAG_SYN' is not an integer constant
> bionic/libc/kernel/common/linux/tcp.h:68:2:
> error: enumerator value for 'TCP_FLAG_FIN' is not an integer constant
> bionic/libc/kernel/common/linux/tcp.h:69:2:
> error: enumerator value for 'TCP_RESERVED_BITS' is not an integer constant
> bionic/libc/kernel/common/linux/tcp.h:71:1:
> error: enumerator value for 'TCP_DATA_OFFSET' is not an integer constant


This https://lkml.org/lkml/2012/8/29/150 should fix the netinet/tcp.h 
build problem.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/