linux-kernel - Re: [PATCH] [perf] Remove the node from rblist in strlist_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Aug 2012 00:29:33 -0600
From:	David Ahern <dsahern@...il.com>
To:	"Suzuki K. Poulose" <suzuki@...ibm.com>
CC:	Arnaldo Carvalho de Melo <acme@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>, ananth@...ibm.com,
	Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH] [perf] Remove the node from rblist in strlist__remove

On 8/29/12 12:00 AM, Suzuki K. Poulose wrote:
> The following commit:
>
> author	David Ahern <dsahern@...il.com>
> 	Tue, 31 Jul 2012 04:31:33 +0000 (22:31 -0600)
> committer	Arnaldo Carvalho de Melo <acme@...hat.com>
> 	Fri, 3 Aug 2012 13:39:51 +0000 (10:39 -0300)
> commit	ee8dd3ca43f151d9fbe1edeef68fb8a77eb9f047
>
> causes a double free during a probe deletion as the node is
> never removed from the list via strlist__remove(), even though
> it gets 'deleted' (read free()'d). This causes a double
> free when we do strlist__delete() as the node is already deleted
> but present in the rblist.
>
> [suzukikp@...ukikp perf]$ sudo ./perf probe -a do_fork
> Added new event:
>    probe:do_fork        (on do_fork)
>
> You can now use it in all perf tools, such as:
>
> 	perf record -e probe:do_fork -aR sleep 1
>
> [suzukikp@...ukikp perf]$ sudo ./perf probe -d do_fork
> Removed event: probe:do_fork
> *** glibc detected *** ./perf: double free or corruption (fasttop): 0x000000000133d600 ***
> ======= Backtrace: =========
> /lib64/libc.so.6[0x38eec7dda6]
> ./perf(rblist__delete+0x5c)[0x47d3dc]
> ./perf(del_perf_probe_events+0xb6)[0x47b826]
> ./perf(cmd_probe+0x471)[0x42c8d1]
> ./perf[0x4150b3]
> ./perf(main+0x501)[0x4148e1]
> /lib64/libc.so.6(__libc_start_main+0xed)[0x38eec2169d]
> ./perf[0x414a61]
>
>
> Make sure we remove the node from the rblist before we delete the
> node. The rblist__remove_node() will invoke rblist->node_delete,
> which  will take care of deleting the node with the suitable function
> provided by the user.
>
> Reported-by: Ananth N. Mavinakayanahalli <ananth@...ibm.com>
> Signed-off-by: Suzuki K. Poulose <suzuki@...ibm.com>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Arnaldo Carvalho de Melo <acme@...radead.org>

Acked-by: David Ahern <dsahern@...il.com>

Same type of change is needed for util/intlist.c if you want to submit 
one, otherwise I will take care of it.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/