linux-kernel - Re: [PATCH RFC] x86/mce: Move MCE sysfs attributes out of the per-cpu location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120829101302.GA26977@aftab.osrc.amd.com>
Date:	Wed, 29 Aug 2012 12:13:02 +0200
From:	Borislav Petkov <bp@...64.org>
To:	"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
Cc:	tony.luck@...el.com, andi@...stfloor.org, ananth@...ibm.com,
	x86@...nel.org, linux-kernel@...r.kernel.org, mingo@...hat.com,
	hpa@...or.com, tglx@...utronix.de, linux-edac@...r.kernel.org
Subject: Re: [PATCH RFC] x86/mce: Move MCE sysfs attributes out of the
 per-cpu location

On Wed, Aug 29, 2012 at 01:11:55PM +0530, Naveen N. Rao wrote:
> All the MCE attributes currently exported via sysfs appear under
> /sys/devices/system/machinecheck/machinecheck<n>/. Pretty much all of these
> are global in nature and not specific to a processor. We have around 7
> attributes duplicated across each processor and on multi-core multi-socket
> machines, this amounts to quite a large number. So, move these out under
> /sys/devices/system/machinecheck/ where they rightly belong.
> 
> Note: I'm not sure if it's ok to change sysfs entries and this does break
> userspace tools that depend on the current path for some of these attributes.
> So, they will need to be updated to use the new path. However, if we ever get
> to a point where cpu0 can be offlined, these tools will need to be updated
> anyway (as they mostly hardcode machinecheck0 currently)

How do you know that for all tools out there?

I know, I know, moving them to /sys/.../machinecheck/ is the right thing
to do but they're exposed to userspace and we're breaking it with this
patch. And we don't break userspace so I'd guess we're stuck with the
current situation.

Sorry.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/