linux-kernel - Re: [PATCH] firmware: fix directory creation rule matching with make 3.82

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120830142754.GB14031@sepie.suse.cz>
Date:	Thu, 30 Aug 2012 16:27:54 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Mark Asselstine <mark.asselstine@...driver.com>
Cc:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] firmware: fix directory creation rule matching with make
 3.82

On Wed, Aug 08, 2012 at 01:14:36PM -0400, Mark Asselstine wrote:
> Attempting to run 'firmware_install' with CONFIG_USB_SERIAL_TI=y when
> using make 3.82 results in an error
> 
> make[2]: *** No rule to make target `/lib/firmware/./', needed by
> `/lib/firmware/ti_3410.fw'.  Stop.
> 
> It turns out make 3.82 is picky when matching directory names with
> trailing slashes as a result, where make 3.81 would handle this
> correctly make 3.82 does not find the rule needed to create the
> directory.
> 
> The './' seen in the error is added by $(dir) for firmware which
> resides in the base firmware src directory, such as
> ti_3410.fw.ihex. By performing $(dir) after we prepend the
> $(INSTALL_FW_PATH) we can ensure we don't end up with a './' in the
> middle of the path and the directory will be properly created.
> 
> This change works with make 3.81 and should work with previous
> versions as well.
> 
> Signed-off-by: Mark Asselstine <mark.asselstine@...driver.com>

Thanks a lot and sorry for the delay. I applied the patch to
kbuild.git#rc-fixes.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/