linux-kernel - Re: [PATCH] [PATCH] usbnet: code clean up using checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Aug 2012 20:58:42 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	"SeungGoo, Kim" <nolja.kim@...sung.com>, davem@...emloft.net
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [PATCH] usbnet: code clean up using checkpatch

On Thursday 30 August 2012 20:18:41 SeungGoo, Kim wrote:
> @@ -748,8 +752,9 @@ int usbnet_open (struct net_device *net)
>                 goto done_nopm;
>         }
>  
> -       // put into "known safe" state
> -       if (info->reset && (retval = info->reset (dev)) < 0) {
> +       /* put into "known safe" state */
> +       retval = info->reset(dev);
> +       if (info->reset && retval < 0) {
>                 netif_info(dev, ifup, dev->net,
>                            "open reset fail (%d) usbnet usb-%s-%s, %s\n",

Dave,

please don't take this patch. It changes code and breaks the driver.
A great big NACK.

Kim,

please do not send coding style patches which change code.
As an exercise think about this piece of code.

	Regards
		Oliver



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/