linux-kernel - Re: [patch v3.6] mm, slab: lock the correct nodelist after reenabling irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 30 Aug 2012 13:15:24 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Haggai Eran <haggaie@...lanox.com>
Cc:	David Rientjes <rientjes@...gle.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Christoph Lameter <cl@...ux.com>
Subject: Re: [patch v3.6] mm, slab: lock the correct nodelist after reenabling irqs

On Wed, Aug 29, 2012 at 2:41 PM, Haggai Eran <haggaie@...lanox.com> wrote:
>> Looks like a problem in 072bb0aa5e0 ("mm: sl[au]b: add knowledge of
>> PFMEMALLOC reserve pages").  cache_grow() can reenable irqs which allows
>> this to be scheduled on a different cpu, possibly with a different node.
>> So it turns out that we lock the wrong node's list_lock because we don't
>> check the new node id when irqs are disabled again.
>>
>> I doubt you can reliably reproduce this, but the following should fix the
>> issue.
> Your patch did solve the issue. Thanks!

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/