linux-kernel - Re: [PATCH 0/8] lp8727

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120830121521.GC11289@lizard>
Date:	Thu, 30 Aug 2012 05:15:21 -0700
From:	Anton Vorontsov <anton.vorontsov@...aro.org>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 0/8] lp8727_charger: cleanup code

On Thu, Aug 30, 2012 at 11:37:16AM +0000, Kim, Milo wrote:
> LP8727 driver should be patched for several reasons.
> 
> (a) Need to clean up _probe()/_remove()
> (b) Not secure code when the platform data is NULL
> (c) Interrupt handling
>     Two threads are running for handling one IRQ.
>     One is for the IRQ pin, the other is used for delayed processing.
>     This is unusual and can be enhanced.
> (d) Misuse of mutex code
> (e) Lots of definitions should be fixed
> (f) Others..

Thanks a lot for the cleanups, this is much appreciated! The cleanups
themselves look great, but I'd really like to see them more separated.

Thanks,
Anton.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/