linux-kernel - Re: i2c-designware-core: KBUILD_MODNAME undeclared [was: Build regressions/improvements in v3.6-rc1]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120831144429.554345d0@endymion.delvare>
Date:	Fri, 31 Aug 2012 14:44:29 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-kernel@...r.kernel.org, dirk.brandewie@...il.com,
	linux-i2c@...r.kernel.org, Michal Marek <mmarek@...e.cz>,
	linux-kbuild@...r.kernel.org, jbaron@...hat.com,
	ben-linux@...ff.org, Jiri Slaby <jirislaby@...il.com>
Subject: Re: i2c-designware-core: KBUILD_MODNAME undeclared [was: Build
 regressions/improvements  in v3.6-rc1]

Hi Jiri, Geert,

On Wed, 15 Aug 2012 22:01:38 +0200, Jiri Slaby wrote:
> On 08/04/2012 11:24 AM, Geert Uytterhoeven wrote:
> > Below is the list of build error/warning regressions/improvements in
> > v3.6-rc1[1] compared to v3.5[2].
> ...
> >   + drivers/i2c/busses/i2c-designware-core.c: error: 'KBUILD_MODNAME' undeclared (first use in this function):
> 
> This is a real problem we are facing here. It happens on PPC when all
> I2C_DESIGNWARE_PLATFORM, I2C_DESIGNWARE_PCI and DYNAMIC_DEBUG are set.
> 
> It's because i2c-designware-core.c is used in two modules
> (i2c-designware-platform and i2c-designware-pci) and KBUILD_MODNAME is
> not defined for those because (scripts/Makefile.lib):
> # $(modname_flags) #defines KBUILD_MODNAME as the name of the module
> # it will end up in (or would, if it gets compiled in)
> # Note: Files that end up in two or more modules are compiled
> #       without the KBUILD_MODNAME definition. The reason is
> #       that any made-up name would differ in different configs.
> 
> But DYNAMIC_DEBUG needs KBUILD_MODNAME for dev_dbg used in that source.
> 
> Any ideas? Why is it not a separate module for example?

It should be. Axel Lin has posted a patch which does that and it should
fix your problem:
https://lkml.org/lkml/2012/6/13/233

Please test and confirm it does the right thing. I'll push the patch
upstream if it does.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/