| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAECXXi7viVEV9eeZ-LvE-wRTDe_r76=1iWffMNPeG1c-Gx5=bA@mail.gmail.com> Date: Fri, 31 Aug 2012 11:24:31 -0400 From: Paul Clements <paul.clements@...sios.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] [RESEND] add discard support to nbd On Thu, Aug 30, 2012 at 6:03 PM, Andrew Morton <akpm@...ux-foundation.org> wrote: > On Wed, 29 Aug 2012 08:41:02 -0400 > paul.clements@...eleye.com wrote: > >> Description: This patch adds discard support to nbd. When the nbd client >> system receives a discard request, this will be passed along to the nbd >> server system, where the nbd-server will respond by performing: >> fallocate(.. FALLOC_FL_PUNCH_HOLE ..) >> >> To punch a hole in the backend storage, which is no longer needed. >> > > What happens if the user is running an older server? In that case, the older server will not have set NBD_SEND_FLAG_TRIM, so QUEUE_FLAG_DISCARD doesn't get set, so no discards will be sent to the device. > I is it possible that because the old server didn't set > NBD_FLAG_SEND_TRIM, the user's screen gets filled with WARN_ONs? No. > Anyway, please make sure this combination was tested! It was. Thanks for the feedback. I will resend v2 of the patches shortly. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists