linux-kernel - Re: [PATCH] [perf] Fix intlist node removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5040E1FD.3060009@gmail.com>
Date:	Fri, 31 Aug 2012 10:10:37 -0600
From:	David Ahern <dsahern@...il.com>
To:	"Suzuki K. Poulose" <suzuki@...ibm.com>,
	Arnaldo Carvalho de Melo <acme@...radead.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [perf] Fix intlist node removal

On 8/31/12 12:58 AM, Suzuki K. Poulose wrote:
> Similar to the one in :
> 	https://lkml.org/lkml/2012/8/29/27
>
>
> Make sure we remove the node from the rblist before we delete the
> node. The rblist__remove_node() will invoke rblist->node_delete,
> which  will take care of deleting the node with the suitable function
> provided by the user.
>
> Signed-off-by: Suzuki K Poulose <suzuki@...ibm.com>
> Cc: David Ahern <dsahern@...il.com>
> ---
>
>   tools/perf/util/intlist.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/intlist.c b/tools/perf/util/intlist.c
> index fd530dc..77c504f 100644
> --- a/tools/perf/util/intlist.c
> +++ b/tools/perf/util/intlist.c
> @@ -52,9 +52,9 @@ int intlist__add(struct intlist *ilist, int i)
>   	return rblist__add_node(&ilist->rblist, (void *)((long)i));
>   }
>
> -void intlist__remove(struct intlist *ilist __used, struct int_node *node)
> +void intlist__remove(struct intlist *ilist, struct int_node *node)
>   {
> -	int_node__delete(node);
> +	rblist__remove_node(&ilist->rblist, &node->rb_node);
>   }
>
>   struct int_node *intlist__find(struct intlist *ilist, int i)
>

Acked-by: David Ahern <dsahern@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/