lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.00.1208312008210.14761@swampdragon.chaosbits.net>
Date:	Fri, 31 Aug 2012 20:09:48 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Cruz Julian Bishop <cruzjbishop@...il.com>
cc:	mcgrof@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux...

On Fri, 31 Aug 2012, Cruz Julian Bishop wrote:

> ...and a big step for learning more Perl.
> 
> Hi!
> 
> This patch set started off as an experiment, but as I continued, I
> realised that I should submit this and see if it's suitable for merging
> into Linux.
> 
> To start off with, here's some patches for checkincludes.pl
> 
> This set was created for the following purposes:
> 
>     1: Making it slightly easier to read
>     2: Making it easier to extend and add new arguments
>     3: Changing the usage output to look more "correct"
>     4: Introducing a 'quiet' mode like checkpatch.pl, and printing
>         messages for files without duplicated includes by default
>        
> Sorry if I did anything wrong - It's my first time really
> experimenting with Perl. 
> 
> Thanks in advance.
> 
> ~Cruz
> 
> Cruz Julian Bishop (4):
>   scripts/checkincludes.pl: Print usage with heredoc
>   scripts/checkincludes.pl: Simplify and shorten argument logic
>   scripts/checkincludes.pl: Fix a bug introduced in the last commit
>   scripts/checkincludes.pl: Introduce 'quiet' mode
> 
>  scripts/checkincludes.pl |  113 ++++++++++++++++++++++++++--------------------
>  1 file changed, 65 insertions(+), 48 deletions(-)
> 
> 
Minor detail. Your patches are for "scripts/checkincludes.pl" but the 
subject says "scripts/checkpatch.pl"... You may want to get it straight 
what you are patching and let the subject reflect reality :-)

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ