linux-kernel - [PATCH 0/1] nbd: fix dangling requests bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <504131c7.p28zUs/mwtoKlH34%paul.clements@steeleye.com>
Date:	Fri, 31 Aug 2012 17:51:03 -0400
From:	paul.clements@...eleye.com
To:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: [PATCH 0/1] nbd: fix dangling requests bug

This patch fixes a serious, but uncommon bug in nbd. This should probably
be considered for backport to one or more stable branches.

The bug occurs when there is heavy I/O going to the nbd device while, at the
same time, a failure (server, network) or manual disconnect of the nbd
connection occurs.

There is a small window between the time that the nbd_thread is stopped and the
socket is shutdown where requests can continue to be queued to nbd's
internal waiting_queue. When this happens, those requests are never completed
or freed.

The fix is to clear the waiting_queue on shutdown of the nbd device, in
the same way that the nbd request queue (queue_head) is already being cleared.

--
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/