| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5043C139.2010700@metafoo.de> Date: Sun, 02 Sep 2012 22:27:37 +0200 From: Lars-Peter Clausen <lars@...afoo.de> To: Thierry Reding <thierry.reding@...onic-design.de> CC: Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org, Antony Pavlov <antonynpavlov@...il.com>, Maarten ter Huurne <maarten@...ewalker.org> Subject: Re: [PATCH 2/3] MIPS: JZ4740: Export timer API On 09/02/2012 10:21 PM, Thierry Reding wrote: > On Sun, Sep 02, 2012 at 04:45:43PM +0200, Lars-Peter Clausen wrote: >> On 09/02/2012 11:52 AM, Thierry Reding wrote: >>> This is a prerequisite for allowing the PWM driver to be converted to >>> the PWM framework. >>> >>> Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de> >> >> I'd prefer to keep the timer functions inline, some of them are called quite >> often in the system clock code. > > I've opted for this variant because it better hides the register values. > If the functions are inlined it also means the complete register > definitions need to go into timer.h. If you don't think that's an issue, > I can update the patch accordingly. > It's not pretty, but it should be ok. Having a single global function for each and every register access is kind of ugly too. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists