linux-kernel - Re: regression 3.5->3.6: usb keyboard not working anymore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201209021153.05364.andres@anarazel.de>
Date:	Sun, 2 Sep 2012 11:53:04 +0200
From:	Andres Freund <andres@...razel.de>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Bernhard Seibold <mail@...nhard-seibold.de>
Subject: Re: regression 3.5->3.6: usb keyboard not working anymore

Hi,

On Sunday, September 02, 2012 10:33:20 AM Jiri Kosina wrote:
> On Thu, 30 Aug 2012, Andres Freund wrote:
> > > With a quick grep I just discovered that a new driver for this (or
> > > similar?) keyboards has been added. I have *not* compiled this in
> > > though: +# CONFIG_HID_LENOVO_TPKBD is not set
> > > 
> > > Is the new, unconditional, entry in the hid_have_special_driver struct
> > > the problem?
> > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > > index 8e3a6b2..f695680 100644
> > > --- a/drivers/hid/hid-core.c
> > > +++ b/drivers/hid/hid-core.c
> > > @@ -1544,6 +1544,7 @@ static const struct hid_device_id
> > > hid_have_special_driver[] = {
> > > 
> > >     { HID_USB_DEVICE(USB_VENDOR_ID_KYE,
> > >     USB_DEVICE_ID_KYE_EASYPEN_M610X) }, {
> > >     HID_USB_DEVICE(USB_VENDOR_ID_LABTEC,
> > > 
> > > USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD) },
> > > 
> > >     { HID_USB_DEVICE(USB_VENDOR_ID_LCPOWER,
> > >     USB_DEVICE_ID_LCPOWER_LC1000 )
> > > 
> > > }, +   { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO,
> > > USB_DEVICE_ID_LENOVO_TPKBD) }, {
> > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_MX3000_RECEIVER)
> > > }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> > > USB_DEVICE_ID_S510_RECEIVER) }, {
> > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_S510_RECEIVER_2)
> > > },
> > > 
> > > Other entries seem to be protected via things like:
> > > #if IS_ENABLED(CONFIG_HID_LOGITECH_DJ)
> > > 
> > > I have somewhat obsoleted my original line of thought in this email,
> > > but hell. Will try this and send a patch if it works.
> > 
> > Works.
> > 
> > Could somebody integrate the attached patch?
> 
> Hmm ... you are right, that this is a regression in a sense that if you
> have a working kernel, do oldconfig with the default settings, and then
> you lose your keyboard.
> 
> I don't like the aproach you used in your patch though ... we are not
> doing this for other devices either. For those, which were previously
> supported by core driver and then a new driver with enhanced support was
> spinned of, we rather make different default config option.
I don't find my approach elegant either. It has the big advantage though that 
you can still walk up to some random computer and be pretty sure the keyboard 
just works without needing to recompile the kernel. Until now it worked on 
every kernel with just CONFIG_USB_HID. Its somewhat harder to recompile a 
kernel without a keyboard...

Greetings,

Andres
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/