linux-kernel - Re: [PATCH 4/5] platform: x86: remove acpi_bus_generate_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120903002336.GD25170@marvin.atrad.com.au>
Date:	Mon, 3 Sep 2012 09:53:36 +0930
From:	Jonathan Woithe <jwoithe@...t42.net>
To:	Davidlohr Bueso <dave@....org>
Cc:	platform-driver-x86@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, mjg@...hat.com
Subject: Re: [PATCH 4/5] platform: x86: remove acpi_bus_generate_proc_event

On Mon, Sep 03, 2012 at 02:03:31AM +0200, Davidlohr Bueso wrote:
> Calling this function no longer makes sense as /proc/acpi/event
> is being removed.
> 
> Signed-off-by: Davidlohr Bueso <dave@....org>
> :
>  drivers/platform/x86/fujitsu-laptop.c   |    4 ----
> :
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index c4c1a54..2fac1c5 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -773,8 +773,6 @@ static void acpi_fujitsu_notify(struct acpi_device *device, u32 event)
>  				else
>  					set_lcd_level(newb);
>  			}
> -			acpi_bus_generate_proc_event(fujitsu->dev,
> -				ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS, 0);
>  			keycode = KEY_BRIGHTNESSUP;
>  		} else if (oldb > newb) {
>  			if (disable_brightness_adjust != 1) {
> @@ -783,8 +781,6 @@ static void acpi_fujitsu_notify(struct acpi_device *device, u32 event)
>  				else
>  					set_lcd_level(newb);
>  			}
> -			acpi_bus_generate_proc_event(fujitsu->dev,
> -				ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS, 0);
>  			keycode = KEY_BRIGHTNESSDOWN;
>  		}
>  		break;

Presumedly the intention here is for these events to be delivered via the
input layer after the removal of /proc/acpi/event (as is done later in the
above function).

If that's the case, then:
  Acked-by: Jonathan Woithe <jwoithe@...t42.net>

Regards
  jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/