linux-kernel - Re: [PATCH 08/13] perf tools: Use __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87392zgbij.fsf@sejong.aot.lge.com>
Date:	Mon, 03 Sep 2012 10:07:00 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Irina Tirdea <irina.tirdea@...il.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 08/13] perf tools: Use __maybe_used for unused variables

Hi,

On Wed, 29 Aug 2012 01:04:25 +0300, Irina Tirdea wrote:
> perf defines __used to for marking unused variables.
> The variable __used is defined to __attribute__((__unused__)), which
> contradicts the kernel definition to __attribute__((__used__))
> for new gcc versions. On Android), __used is also defined in
> system headers and this leads to warnings like:
> warning: '__used__' attribute ignored
>
> This patch simply replaces all instances of __used with __maybe_unused
> so there will be no such warnings.

How about just using '__unused' for less typing?

Btw, the patch looks whitespace-damaged.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/