linux-kernel - Re: [PATCH] hid: Remove "default m" from HID_LOGITECH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1209031449140.20709@pobox.suse.cz>
Date:	Mon, 3 Sep 2012 14:49:42 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] hid: Remove "default m" from HID_LOGITECH_DJ

On Sun, 2 Sep 2012, Josh Triplett wrote:

> HID_LOGITECH_DJ uses "default m", which enables it in default kernel
> builds.  Since this module just enables extra, non-critical
> functionality for one particular piece of hardware (specifically,
> differentiating multiple wireless keyboards and mice as separate input
> devices rather than treating them as one device), and the hardware works
> just fine with the default USB HID support, drop the "default m".
> 
> Signed-off-by: Josh Triplett <josh@...htriplett.org>
> ---
>  drivers/hid/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index fbf4950..d004528 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -307,7 +307,6 @@ config HID_LOGITECH
>  config HID_LOGITECH_DJ
>  	tristate "Logitech Unifying receivers full support"
>  	depends on HID_LOGITECH
> -	default m
>  	---help---
>  	Say Y if you want support for Logitech Unifying receivers and devices.
>  	Unifying receivers are capable of pairing up to 6 Logitech compliant

That was an overlook on my side when merging the driver. Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/