linux-kernel - Re: [PATCH v2 20/31] arm64: User access library function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120903125810.GB3313@mbp>
Date:	Mon, 3 Sep 2012 13:58:11 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Will Deacon <Will.Deacon@....com>,
	Marc Zyngier <Marc.Zyngier@....com>
Subject: Re: [PATCH v2 20/31] arm64: User access library function

On Wed, Aug 15, 2012 at 03:49:54PM +0100, Arnd Bergmann wrote:
> On Tuesday 14 August 2012, Catalin Marinas wrote:
> 
> > +/*
> > + * Single-value transfer routines.  They automatically use the right
> > + * size if we just have the right pointer type.  Note that the functions
> > + * which read from user space (*get_*) need to take care not to leak
> > + * kernel data even if the calling code is buggy and fails to check
> > + * the return value.  This means zeroing out the destination variable
> > + * or buffer on error.  Normally this is done out of line by the
> > + * fixup code, but there are a few places where it intrudes on the
> > + * main code path.  When we only write to user space, there is no
> > + * problem.
> > + */
> > +extern long __get_user_1(void *);
> > +extern long __get_user_2(void *);
> > +extern long __get_user_4(void *);
> > +extern long __get_user_8(void *);
> > +
> > +#define __get_user_x(__r2,__p,__e,__s,__i...)				\
> > +	   asm volatile(						\
> > +		__asmeq("%0", "x0") __asmeq("%1", "x2")			\
> > +		"bl	__get_user_" #__s				\
> > +		: "=&r" (__e), "=r" (__r2)				\
> > +		: "0" (__p)						\
> > +		: __i, "cc")
> > +
> > +#define get_user(x,p)							\
> > +	({								\
> > +		register const typeof(*(p)) __user *__p asm("x0") = (p);\
> > +		register unsigned long __r2 asm("x2");			\
> > +		register long __e asm("x0");				\
> > +		switch (sizeof(*(__p))) {				\
> > +		case 1:							\
> > +			__get_user_x(__r2, __p, __e, 1, "x30");		\
> > +			break;						\
> > +		case 2:							\
> > +			__get_user_x(__r2, __p, __e, 2, "x3", "x30");	\
> > +			break;						\
> > +		case 4:							\
> > +			__get_user_x(__r2, __p, __e, 4, "x30");		\
> > +			break;						\
> > +		case 8:							\
> > +			__get_user_x(__r2, __p, __e, 8, "x30");		\
> > +			break;						\
> > +		default: __e = __get_user_bad(); break;			\
> > +		}							\
> > +		x = (typeof(*(p))) __r2;				\
> > +		__e;							\
> > +	})
> 
> It's fairly unusual to have out of line get_user/put_user functions.
> What is the reason for this, other than copying from ARM?

I changed these to inline asm. The only reason which I don't think
matters much in this case is a few KB increase in Image size.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/