linux-kernel - [PATCH] virtio: Don't access device data after unregistration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1346680242-5717-1-git-send-email-sjur.brandeland@stericsson.com>
Date:	Mon,  3 Sep 2012 15:50:42 +0200
From:	sjur.brandeland@...ricsson.com
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Sjur Brændeland <sjurbren@...il.com>,
	linux-kernel@...r.kernel.org,
	Sjur Brændeland <sjur.brandeland@...ricsson.com>,
	"Guzman Lugo, Fernadndo" <fernando.lugo@...com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	virtualization@...ts.linux-foundation.org,
	Ohad Ben-Cohen <ohad@...ery.com>
Subject: [PATCH] virtio: Don't access device data after unregistration.

From: Sjur Brændeland <sjur.brandeland@...ricsson.com>

Fix panic in virtio.c when CONFIG_DEBUG_SLAB is set.
Use device_del() and put_device() instead of
device_unregister(), and access device data before
calling put_device().


Signed-off-by: Sjur Brændeland <sjur.brandeland@...ricsson.com>
cc: Guzman Lugo, Fernadndo <fernando.lugo@...com>
cc: Michael S. Tsirkin <mst@...hat.com>
cc: virtualization@...ts.linux-foundation.org
cc: Ohad Ben-Cohen <ohad@...ery.com>
---
 drivers/virtio/virtio.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index c3b3f7f..71eacd1 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -225,8 +225,9 @@ EXPORT_SYMBOL_GPL(register_virtio_device);
 
 void unregister_virtio_device(struct virtio_device *dev)
 {
-	device_unregister(&dev->dev);
+	device_del(&dev->dev);
 	ida_simple_remove(&virtio_index_ida, dev->index);
+	put_device(&dev->dev);
 }
 EXPORT_SYMBOL_GPL(unregister_virtio_device);
 
-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/