[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120903.155332.1814926007061594344.davem@davemloft.net>
Date: Mon, 03 Sep 2012 15:53:32 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: chikazawa.akifu@...fujitsu.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: when the MTU interface is modified, the promiscuous mode is
reset in gianfar driver
From: chikazawa.akifu@...fujitsu.com (近沢 哲史)
Date: Mon, 27 Aug 2012 17:38:34 +0900
> I am using the gianfar ethernet driver. I am having a problem with the
> interface settings.
> Under promiscuous mode, when the MTU interface is modified, the promiscuous
> mode setting is turned off in gianfar driver when it should not be.
> The details are as follows:
> After changing MTU with ifconfig, I could see that the interface flag of
> eth0 is still PROMISC.
> However, when I checked value of RCTL register with ethtool, PROM bit of
> RTCL register is cleared.
> It seems to be cause that is the gfar_init_mac() function, it doesn't set
> the PROM bit after the interface MTU is changed.
> This problem was detected on linux-2.6.32.2, but it seems to same on
> linux-3.6.0-rc3.
> Is this behavior on purpose?
>
> I also attach the amended file,I think it would be so.
>
> Signed-off-by: Akifumi Chikazawa <chikazawa.akifu@...fujitsu.com>
It seems like we also lose all of the multicast configurations as
well.
Therefore, the thing to do is to simply call gfar_set_multi() at the
appropriate location. That will take care of both the promiscuous
bit, as well as the multicast addresses.
You can then remove some of the code in gfar_init_mac() that does
things like gfar_clear_exact_match(), because gfar_set_multi() will
take care of that if necessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists